Adding TechDemo 25: Cardiovascular Stent Simulation #15

clatapie · 2022-11-24T09:54:31Z

Closes #10

…mapdl-techdemos into doc/adding_techdemo25

germa89

I just realised it is a draft xD...

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.rst

germa89 · 2022-11-28T09:57:18Z

@clatapie ping also Kathy when the main of the text is ready.

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.ipynb

…mapdl-techdemos into doc/adding_techdemo25

germa89 · 2022-12-13T14:31:21Z

I'm removing myself from reviewers, re-add me when this draft is ready to be reviewed.

…mapdl-techdemos into doc/adding_techdemo25

doc/source/conf.py

doc/source/technology_showcase_examples/techdemo-15/ex_15-teccalvalhyper.rst

…alvalhyper.rst

…mapdl-techdemos into doc/adding_techdemo25

.github/workflows/ci_cd.yml

RobPasMue · 2023-01-10T14:06:08Z

Starting final review! :)

RobPasMue

LGTM! Just one minor comment. I'm no expert on the techdemo itself, so I trust your implementation. Thanks @clatapie, great work!!!

requirements/requirements_doc.txt

Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>

germa89

Nice work!

Let's see how it looks once it has been deployed.

Some comments:

Some of the images are very small.
you are attaching db files, But I'm not sure if you are using them all. For example stent.db.

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.py

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.ipynb

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.py

germa89 · 2023-01-10T14:53:04Z

doc/source/index.rst

+.. ##########
+
+.. raw:: html
+
+    <div class="sphx-glr-thumbcontainer" tooltip="Technology Showcase Example 15: Calibrating and Validating a Hyperelastic Constitutive Model">
+
+.. only:: html
+
+  .. image:: technology_showcase_examples/images/thumb/sphx_glr_tse-015-calvalhyper_thumb.gif
+    :alt: Calibrating and Validating a Hyperelastic Constitutive Model
+
+  :ref:`sphx_glr_ex_15-teccalvalhyper.rst`
+
+.. raw:: html
+
+      <div class="sphx-glr-thumbnail-title">Calibrating and Validating a Hyperelastic Constitutive Model</div>
+    </div>
+
+.. #########


I guess this is generated by sphinx?

I extended it: I don't have an example repository so I don't generate the Sphinx gallery like PyMAPDL or PyMAPDL-examples do. Let me know if it's not good practice!

doc/source/index.rst

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.py

…mapdl-techdemos into doc/adding_techdemo25

Co-authored-by: German <28149841+germa89@users.noreply.github.com>

clatapie · 2023-01-11T10:55:09Z

Hello @PipKat,
I'm pinging you to get your feedbacks on this new repository and the new TechDemo example.
Please, feel free to let me know if you want me to make any changes.

akaszynski

There is a bunch of generated content here that shouldn't be included in this PR.

Let's remove everything that's generated and instead make it procedural by using sphinx-gallery or myst-nb as used in pygeometry.

Adding folder and modifying index

aa858e5

clatapie requested a review from RobPasMue November 24, 2022 09:54

clatapie self-assigned this Nov 24, 2022

clatapie linked an issue Nov 24, 2022 that may be closed by this pull request

TechDemo 25: Cardiovascular Stent Simulation #10

Closed

github-actions bot added the documentation Improvements or additions to documentation label Nov 24, 2022

clatapie and others added 6 commits November 24, 2022 12:50

Modifying the TechDemo25 Python file

15956f3

Adding a work in process flag in Python file

0318d17

Merge branch 'main' into doc/adding_techdemo25

5340826

Merge branch 'main' into doc/adding_techdemo25

6576a72

Changing depth property of toctree

65574f3

Merge branch 'doc/adding_techdemo25' of https://github.com/pyansys/py…

60255d1

…mapdl-techdemos into doc/adding_techdemo25

clatapie requested a review from germa89 November 25, 2022 17:08

Merge branch 'main' into doc/adding_techdemo25

393b704

germa89 approved these changes Nov 28, 2022

View reviewed changes

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.rst Outdated Show resolved Hide resolved

Modifying the Jupyter Notebook file

c2b6b0d

germa89 reviewed Nov 29, 2022

View reviewed changes

doc/source/technology_showcase_examples/techdemo-25/ex_25-tecstent.ipynb Outdated Show resolved Hide resolved

clatapie and others added 8 commits November 30, 2022 14:27

Plotting displacements and stress

d61045f

Jupyter file, Python file and RST file

e950d2c

Merge branch 'main' into doc/adding_techdemo25

522e4b0

Exporting vtk files to create semi-static example

4e84952

Merge branch 'doc/adding_techdemo25' of https://github.com/pyansys/py…

23aaa8b

…mapdl-techdemos into doc/adding_techdemo25

Merge branch 'main' into doc/adding_techdemo25

00b2e9c

Merge branch 'main' into doc/adding_techdemo25

a22fb25

Merge branch 'main' into doc/adding_techdemo25

db18728

clatapie and others added 3 commits December 27, 2022 09:24

Merge branch 'main' into doc/adding_techdemo25

e9b3039

Fixing the vtk plots

7378bb7

Merge branch 'doc/adding_techdemo25' of https://github.com/pyansys/py…

73318ad

…mapdl-techdemos into doc/adding_techdemo25

github-actions bot added the dependencies Related with project dependencies label Dec 27, 2022

clatapie added 3 commits January 10, 2023 10:05

Fixing an issue in conf.py file

277247f

Fixing a RST issue on ex_20

c0343f5

Fixing warning VTK error

02421f5

RobPasMue reviewed Jan 10, 2023

View reviewed changes

doc/source/conf.py Show resolved Hide resolved

RobPasMue reviewed Jan 10, 2023

View reviewed changes

doc/source/technology_showcase_examples/techdemo-15/ex_15-teccalvalhyper.rst Outdated Show resolved Hide resolved

RobPasMue and others added 4 commits January 10, 2023 12:38

Update doc/source/technology_showcase_examples/techdemo-15/ex_15-tecc…

20a1775

…alvalhyper.rst

Fixing the warning issue

0dfa7a7

Merge branch 'doc/adding_techdemo25' of https://github.com/pyansys/py…

b4da213

…mapdl-techdemos into doc/adding_techdemo25

Fixing warning level in the CI/CD

85883ac

github-actions bot added the maintenance Package and maintenance related label Jan 10, 2023

RobPasMue reviewed Jan 10, 2023

View reviewed changes

.github/workflows/ci_cd.yml Show resolved Hide resolved

Fixing the warning level in the CI/CD

6e07df0

RobPasMue approved these changes Jan 10, 2023

View reviewed changes

requirements/requirements_doc.txt Outdated Show resolved Hide resolved

RobPasMue marked this pull request as ready for review January 10, 2023 14:21

clatapie and others added 2 commits January 10, 2023 15:26

Updating the python file

c1eecac

Update requirements/requirements_doc.txt

54ad689

Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>

clatapie requested a review from germa89 January 10, 2023 14:30

germa89 approved these changes Jan 10, 2023

View reviewed changes

clatapie and others added 5 commits January 10, 2023 16:32

Cleaning the techdemo25 summarry

b439847

Merge branch 'doc/adding_techdemo25' of https://github.com/pyansys/py…

5e9e322

…mapdl-techdemos into doc/adding_techdemo25

Apply suggestions from code review

deea071

Co-authored-by: German <28149841+germa89@users.noreply.github.com>

Apply changes from German's review

bca2fce

Fixing formatting issues

746c67f

clatapie requested a review from PipKat January 11, 2023 10:55

Modifying plots/ images sizes + removing stent.db

62b607e

akaszynski suggested changes Jan 11, 2023

View reviewed changes

clatapie closed this Jan 12, 2023

germa89 deleted the doc/adding_techdemo25 branch February 26, 2023 07:56

Adding TechDemo 25: Cardiovascular Stent Simulation #15

Adding TechDemo 25: Cardiovascular Stent Simulation #15

Uh oh!

Conversation

clatapie commented Nov 24, 2022

Uh oh!

germa89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

germa89 commented Nov 28, 2022

Uh oh!

Uh oh!

germa89 commented Dec 13, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue commented Jan 10, 2023

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

germa89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

germa89 Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

clatapie Jan 10, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

clatapie commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akaszynski left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

clatapie commented Jan 11, 2023 •

edited

Loading